From: Ian Campbell Date: Fri, 9 Dec 2011 12:01:16 +0000 (+0000) Subject: libxl: fix cold plugged PCI devices with stubdomains X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=18f93842ac3c2ca4e985497ea5e9f4d7e8fdfeaf;p=xen.git libxl: fix cold plugged PCI devices with stubdomains Since 23565:72eafe80ebc1 the xenstore entries for the stubdomain's PCI were never created and therefore the stubdom ends up waiting forever for the devices which it has been asked to insert to show up. Since the stubdomain is already running when we call the libxl_device_pci_add loop in do_domain_create we should treat it as if "starting == 0". Signed-off-by: Ian Campbell Acked-by: Ian Jackson Committed-by: Ian Jackson Acked-by: Ian Jackson Acked-by: Stefano Stabellini --- diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 120c2397c1..8b2a1c5b77 100644 --- a/tools/libxl/libxl_pci.c +++ b/tools/libxl/libxl_pci.c @@ -814,7 +814,8 @@ int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcide stubdomid = libxl_get_stubdom_id(ctx, domid); if (stubdomid != 0) { libxl_device_pci pcidev_s = *pcidev; - rc = do_pci_add(gc, stubdomid, &pcidev_s, starting); + /* stubdomain is always running by now, even at create time */ + rc = do_pci_add(gc, stubdomid, &pcidev_s, 0); if ( rc ) goto out; }